Closed nleroy917 closed 4 months ago
@khoroshevskyi anything else?
Still investigating some weirdness with the way that the network requests hang for config
, subsamples
, and views
It seems like Save
button is available in the views, and I can modify sample table
Still investigating some weirdness with the way that the network requests hang for
config
,subsamples
, andviews
This problem can be realted to this issue: https://github.com/pepkit/pepdbagent/issues/128
This problem can be realted to this issue: pepkit/pepdbagent#128
Close, but no. It's the validation that's causing issues. Validating that sample table takes a really long time, so I need to make sure to run that only if the project has less than 5,000 samples
Instead of a popup, just replace the sample table with a message that says its not going to display the sample table, and tell you to set the view at the top to see samples
User feedback (not from me):
pepdbagent.views.get_annotation(...)
MOST important: add info about that, how to modify it
Description of the each view is missing (it is one of the annotations). pepdbagent.views.get_annotation(...)
I agree this is ideal, but real estate is getting cramped up there already... what sort of UI component could we render that adds a description while not making it too large? I could add it to the "More" dropdown and make it a modal
Overview
This PR integrates the views API into the actual user interface of PEPhub. Its quite simple and provides a dropdown where users can select a view to replace the sample table instead of viewing the entire thing. Moreover, it adds functionality to only pull the sample table if the project annotation indicates that the sample able is less than some maximum value (
5,000
right now).If this threshold is broken, it displays a warning to the user telling them to select a view instead.
Relevant issues
274
289
Screnshots
Warning popup:
View selector:
TODO: