pepkit / pephub

A web API and database for biological sample metadata
https://pephub.databio.org
BSD 2-Clause "Simplified" License
12 stars 2 forks source link

Moving to 'config' tab loses all unsaved changes in 'samples' tab #346

Closed nsheff closed 1 month ago

nsheff commented 1 month ago

Steps to reproduce:

  1. make some changes in sample table.
  2. don't save yet; switch to config to make some changes there.
  3. go back to 'samples' -- all your changes will be gone.
  4. go back to 'config' -- all your changes will be gone again.
nsheff commented 1 month ago

Now it's trying to be smart and prevent me from saving the file with a broken sample_table_index:

image

But the thing is, I can't change it, because I can't go to that tab and take away sample_name, because then it gives me the same error in the other direction!

nsheff commented 1 month ago

Maybe related to #338 ?

khoroshevskyi commented 1 month ago

Also faced with this issue, I would say it should be fixed ASAP