Closed khoroshevskyi closed 9 months ago
you said phc.view.get(...)
but there is no .view
anywhere... there is Views
-- is that what you mean? I don't quite follow, can you add some documentation to explain this further? (ideally in the code itself, rather than in the PR comments)
@nsheff ok, I will add docstring!
For clarity: I am calling PEPHubClient().view
, because I added property, that will return initialized class Views. User won't even see this class. I did it for modularity, so it will be easier to maintain code
Just some thoughts/questions as I read this PR...
Regarding future implementation with Pipestat:
This PR is outdated
The purpose of this pull request is to review the API for samples and views endpoints, intended for use in bedboss and pipestat. Currently, it is only a skeleton without functionality. Before proceeding with the implementation of actual functionality, I would like to hear your opinion.
Example how it should work:
@donaldcampbelljr I would like to hear also your opinion about it, because in the future you can use it for pephub backend implementation in pipestat