search

pepkit / peppy

Project metadata manager for PEPs in Python
https://pep.databio.org/peppy
BSD 2-Clause "Simplified" License
37 stars 13 forks source link

Avoid pandas.DataFrame.append #377

Closed J-Wall closed 2 years ago

J-Wall commented 2 years ago

The append method on pandas DataFrames is deprecated (see pandas-dev/pandas#35407). Peppy uses this to build the sample table, leading to verbose FutureWarning output from pandas. It's also probably not the most efficient way of making the table.

Instead of appending to an existing DataFrame in project._get_table_from_samples, perhaps a python list should be used, and then converted to a DataFrame after the for loop?

J-Wall commented 2 years ago

I just realised this was solved in #367. Are there plans to merge and release that soon? Thanks!

nsheff commented 2 years ago

Yes I am planning to release later this month

J-Wall commented 2 years ago

fixed in v0.32.0

Kekananen commented 2 years ago

Do you know if v0.32.0 will be available on conda soon as well?