pepkit / peppy

Project metadata manager for PEPs in Python
https://pep.databio.org/peppy
BSD 2-Clause "Simplified" License
37 stars 13 forks source link

from_pandas() function does not initialize '_subsample_df' variable #401

Closed khoroshevskyi closed 2 years ago

khoroshevskyi commented 2 years ago

subsample_df was not initialized when Project was initializing from_pandas(). This issue leads next error:

>>> asff = dbc.get_project_by_registry('GEO/GSE146537_samples')
[INFO] [18:40:48] Project has been found: 218
Detecting duplicate sample names ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━   0% -:--:--
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/bnt4me/.local/lib/python3.8/site-packages/pepagent/pepagent.py", line 261, in get_project_by_registry
    return self.get_project(namespace=namespace, name=name, tag=tag)
  File "/home/bnt4me/.local/lib/python3.8/site-packages/pepagent/pepagent.py", line 294, in get_project
    return peppy.Project().from_dict(project_value)
  File "/home/bnt4me/.local/lib/python3.8/site-packages/peppy/project.py", line 277, in from_dict
    if pep_dictionary[SUBSAMPLE_DF_KEY] is not None:
KeyError: '_subsample_df'