search

pepkit / peppy

Project metadata manager for PEPs in Python
https://pep.databio.org/peppy
BSD 2-Clause "Simplified" License
37 stars 13 forks source link

disabled progress bar #425

Closed khoroshevskyi closed 1 year ago

khoroshevskyi commented 1 year ago

Disabled progress bar that was printing while checking duplicated sample names.

nsheff commented 1 year ago

remove dependency, imports, etc.

khoroshevskyi commented 1 year ago

Hi @stolarczyk , was there any specific reason you used track function while iterating list and other objects? e.g. https://github.com/pepkit/peppy/blob/29505052700cfa73068570ebc8899d6508c4366b/peppy/project.py#L473 https://github.com/pepkit/peppy/blob/29505052700cfa73068570ebc8899d6508c4366b/peppy/project.py#L490 https://github.com/pepkit/peppy/blob/29505052700cfa73068570ebc8899d6508c4366b/peppy/project.py#L506

stolarczyk commented 1 year ago

That's solely to improve UX. It conditionally displays a progress bar for each sample modifier for large sample tables.

If you're planning to remove it, it should have no downstream effects.

khoroshevskyi commented 1 year ago

That's solely to improve UX. It conditionally displays a progress bar for each sample modifier for large sample tables.

If you're planning to remove it, it should have no downstream effects.

Ok, thanks! There was a bug, so this progress bar was printed always. I will fix it.