search

pepkit / peppy

Project metadata manager for PEPs in Python
https://pep.databio.org/peppy
BSD 2-Clause "Simplified" License
37 stars 13 forks source link

Add functionality that supports non private keys in dictionary in `from_dict` fucntion #437

Closed khoroshevskyi closed 1 year ago

khoroshevskyi commented 1 year ago

Few month ago I implemented to_dict and from_dict functionality to peppy. At that time I didn't know that we shouldn't return private variables (or dictionary with keys that start with underscore: eg. "_sample_dict"). This way of returning peppy as dictionary is incorrect and can lead to downstream problem.

  1. I suggest change this functionality, so to_dict will return all non-private keys.
  2. from_dict will support dict with both private and non-private keys.
khoroshevskyi commented 1 year ago

After discussion, decided not to change it