pepkit / peppy

Project metadata manager for PEPs in Python
https://pep.databio.org/peppy
BSD 2-Clause "Simplified" License
37 stars 12 forks source link

`to_dict(extended=True)` is producing dict with incorrect key name `subsample_dict` #442

Closed khoroshevskyi closed 1 year ago

khoroshevskyi commented 1 year ago

project.to_dict() returns project dict, but one of the variables (keys) has incorrect name.: subsample_dict is a list of subsamples, not a dict. Correct key name should be subsample_list.

We should change it in the future. Additionally we should be caution about this change, as it can lead to errors in pephub, pepdbagent and pephubclient:/

https://github.com/pepkit/peppy/blob/8449635bb35e16748e693bdd2c4820502d7b448d/peppy/project.py#L243-L249

https://github.com/pepkit/peppy/blob/8449635bb35e16748e693bdd2c4820502d7b448d/peppy/const.py#L122