search

pepkit / peppy

Project metadata manager for PEPs in Python
https://pep.databio.org/peppy
BSD 2-Clause "Simplified" License
37 stars 12 forks source link

Using v0.40.0 can create peppy project without sample names. #473

Open donaldcampbelljr opened 6 months ago

donaldcampbelljr commented 6 months ago

Example:

sample_name,library,file,toggle
,anySampleType,data/frog1_data.txt,1
frog_2,anySampleType,data/frog2_data.txt,1

Can create peppy prj with missing sample name.

sample_name: None
library:     anySampleType
file:        data/frog1_data.txt
toggle:      1, Sample 'frog_2' in Project (/home/drc/GITHUB/hello_looper/hello_looper/project/project_config.yaml)

sample_name: frog_2
library:     anySampleType
file:        data/frog2_data.txt
toggle:      1]
khoroshevskyi commented 1 week ago

After investigating this issue, it seems it is correct behavior. Sample name can be derived. And we have few tests for that. https://github.com/pepkit/peppy/blob/fc15511acf420d5862c4650502a43df448e507b0/tests/test_Project.py#L290-L299