pepkit / peppy

Project metadata manager for PEPs in Python
https://pep.databio.org/peppy
BSD 2-Clause "Simplified" License
37 stars 13 forks source link

peppy 0.40.6 and 0.40.7 lead to eido validation error #496

Open johanneskoester opened 3 weeks ago

johanneskoester commented 3 weeks ago

The error is

eido.exceptions.EidoValidationError: EidoValidationError (Validation failed): {"'_samples' is a required property": [{'type': "'_samples' is a required property", 'message': "'_samples' is a required property on instance project", 'sample_name': 'project'}]}

It worked fine before with 0.40.5.

config.yaml:

pep_version: "2.0.0"
sample_table: sample_table.csv

sample_table.csv:

sample_name,protocol
a,test
b,test2
khoroshevskyi commented 3 weeks ago

Hello Johannes, Can you please try to update eido to a newer version, and check if it helps? (eido == 0.2.4)

We were working on improving eido validation, and we made changes that broke backwards compatibility. (in peppy and eido)

nsheff commented 2 weeks ago

This is because the eido conda build is out-of-date.

We need to fix the conda build issue.

Same issue as this: https://github.com/pepkit/eido/issues/78