Closed nsheff closed 5 months ago
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
6c4797c
) 54.51% compared to head (dc47361
) 54.56%.
Files | Patch % | Lines |
---|---|---|
pipestat/pipestat.py | 71.42% | 2 Missing :warning: |
pipestat/backends/file_backend/filebackend.py | 90.90% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ok, I think I've got this completed. One thing is that the new functionality is a bit messier to implement:
self.cfg[CONFIG_KEY] = YAMLConfigManager(
entries=config_dict, filepath=self.cfg["config_path"]
)
becomes
if config_dict is not None:
self.cfg[CONFIG_KEY] = YAMLConfigManager.from_obj(entries=config_dict)
elif self.cfg["config_path"] is not None:
self.cfg[CONFIG_KEY] = YAMLConfigManager.from_yaml_file(filepath=self.cfg["config_path"])
else:
self.cfg[CONFIG_KEY] = YAMLConfigManager()
Draft PR of changes to make pipestat compatible with yacman v0.9.3, in prep for yacman v1