pepkit / pipestat

Pipeline results reporting package
https://pep.databio.org/pipestat/
BSD 2-Clause "Simplified" License
4 stars 2 forks source link

Retrieve is not using the pipestatmanager object record_identifier if none is supplied #175

Closed donaldcampbelljr closed 3 months ago

donaldcampbelljr commented 3 months ago
          Regarding 

why can't retrieve use the class record identifier?

With the above example, psm.retrieve_one("value") , pipestat thinks that value is the record_identifier.

image

However, if I attempt to specify the arguments, result = psm.retrieve_one(result_identifier="value"), I see that there is a problem and pipestat is not pulling the class record_identifier appropriately.

psm1 = PipestatManager(record_identifier="RECORD1", schema_path="sample_output_schema.yaml", results_file_path="results.yaml", pipeline_type="sample")
psm1.report(values={"number_of_things": 100})
result = psm1.retrieve_one(result_identifier="number_of_things")

Error

  File "/home/drc/PythonProjects/pipestat/opt_dependencies/venv6/lib/python3.10/site-packages/pipestat/pipestat.py", line 708, in retrieve_one
    raise RecordNotFoundError(
pipestat.exceptions.RecordNotFoundError: Results '['number_of_things']' for 'None' not found

Originally posted by @donaldcampbelljr in https://github.com/pepkit/pipestat/issues/158#issuecomment-2037517270

donaldcampbelljr commented 3 months ago

This is now fixed