pepkit / pipestat

Pipeline results reporting package
https://pep.databio.org/pipestat/
BSD 2-Clause "Simplified" License
4 stars 2 forks source link

Create History for Filebackend and DB Backend #178

Closed donaldcampbelljr closed 3 months ago

donaldcampbelljr commented 3 months ago

Addresses: https://github.com/pepkit/pipestat/issues/177

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 12.64368% with 76 lines in your changes are missing coverage. Please review.

Project coverage is 54.01%. Comparing base (30bcccd) to head (8001551).

:exclamation: Current head 8001551 differs from pull request most recent head 2cf054c. Consider uploading reports for the commit 2cf054c to get more accurate results

Files Patch % Lines
pipestat/backends/db_backend/dbbackend.py 4.34% 44 Missing :warning:
pipestat/backends/db_backend/db_parsed_schema.py 4.54% 21 Missing :warning:
pipestat/pipestat.py 9.09% 10 Missing :warning:
pipestat/backends/file_backend/filebackend.py 87.50% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #178 +/- ## ========================================== - Coverage 55.56% 54.01% -1.56% ========================================== Files 15 15 Lines 2318 2405 +87 ========================================== + Hits 1288 1299 +11 - Misses 1030 1106 +76 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

donaldcampbelljr commented 3 months ago

Some suggested changes after today's discussion:

donaldcampbelljr commented 3 months ago

Ok, I've added most of the above suggestions. File backend history now looks like this:

default_pipeline_name:
  project: {}
  sample:
    sample1:
      meta:
        pipestat_modified_time: '2024-04-16 15:34:57'
        pipestat_created_time: '2024-04-16 15:34:56'
        history:
          name_of_something:
            '2024-04-16 15:34:57': test_name
          number_of_things:
            '2024-04-16 15:34:57': 1
      name_of_something: MODIFIED_test_name
      number_of_things: 2