search

peplin / arduino.mk

DEPRECATED FORK: Arduino Makefile with chipKIT support
http://christopherpeplin.com/2011/12/chipkit-arduino-makefile/
GNU Lesser General Public License v2.1
11 stars 4 forks source link

Step-by-step pull requests #8

Closed rei-vilo closed 12 years ago

rei-vilo commented 12 years ago

1- Added files

ReadMe_ReiVilo.md
References.txt
Blink.pde
rei-vilo commented 12 years ago

2- Added Xcode project

Xcode project main makefile with switch to Arduino.mk or chipKIT.mk

rei-vilo commented 12 years ago

3- Fixed _BOARDMEGA hard-coded in chipKIT.mk

rei-vilo commented 12 years ago

5- Debug comments on makefiles

cleaner commit @echo " ---- debug comment ---- " see issue #7

Results

Both tested on Xcode and Terminal

rei-vilo commented 12 years ago

6- Added LDSCRIPT value search

LDSCRIPT used afterwards LDSCRIPT seems to be related to link phase

Maybe some hints here with corresponding makefile [there](http://pastebin. com/31XXwmUV).

rei-vilo commented 12 years ago

7- Added EXTRA_LDFLAGS for linker

The link script reference was missing.

The blink.pde works now!

However, adding a library #include "Wire.h" raises an error

build-cli/Blink.cpp: 4: 18: error: Wire.h: No such file or directory make: *\ [build-cli/Blink.d] Error 1

Each library needs to be declared manually in ARDUINO_LIBS

rei-vilo commented 12 years ago

8- Library issue solved

ARDUINO_LIB_PATH fixed was = $(ARDUINO_SKETCHBOOK)/libraries now = $(ARDUINO_DIR)/hardware/pic32/libraries

more powerful clean

info section added for debugging

rei-vilo commented 12 years ago

Feel free!

rei-vilo commented 12 years ago

9- Xcode implementation

but no code sense yet

GitHub doesn't like Mac :(

peplin commented 12 years ago

Hey, could you use separate issues and pull requests? I just pushed a few commits that includes some of the fixes you made, but when you combine them into one pull request it's impossible to merge automatically. You have to file separate pull requests, not just add new commits to the same one. Thanks, Olivier!

rei-vilo commented 12 years ago

GitHub went messy for the 9- pull request. Sorry. I'm afraid GitHub is fighting with Xcode own implementation.

When I ask for a pull request, an issue is opened. Is it a feature or a bug?

Anyway, pull request 9 does work.

To be done: implement code sense, include user's libraries.

peplin commented 12 years ago

That's a feature, I believe - the intent is that each bug has one pull request with the fix. I'm working on user libraries right now, without much luck so far. That's why I had the ARDUINO_LIBS path switched.

There's an implementation here (https://github.com/rngtng/Arduino.mk/commit/9ceda5e9ba299c21f70713c1020b81595a764d31) but i can't get it to work properly.