search

pepp97 / ing-sw-2020-asaro-cassata-cecco

0 stars 1 forks source link

hard-coded values #4

Closed ingconti closed 4 years ago

ingconti commented 4 years ago

pols remove hard-coded values as in:

SquareToJson[][]map=new SquareToJson[5][5];
    Square [][]mappa=controller.getGame().getField().getSquares();

    for(int i=0;i<5;i++)
        for(int j=0; j<5;j++)

...

use final static... and so on...

RiccardoCecco commented 4 years ago

scusi, non abbiamo capito quale sarebbe l'errore, potrebbe essere più specifico?

michele-bertoni commented 4 years ago

The problem is the number 5.

ingconti commented 4 years ago

I make a ref to "https://beep.metid.polimi.it/web/2019-20-prova-finale-ingegneria-del-software-alessandro-margara-/documenti-e-media?p_p_id=20&p_p_lifecycle=0&p_p_state=normal&p_p_mode=view&_20_struts_action=%2Fdocument_library%2Fview_file_entry&_20_fileEntryId=181617309&#p_20"

(slide 3 and 5 for example)

at slide:

RiccardoCecco commented 4 years ago

fixed

ingconti commented 4 years ago

good!