Laravel 8 support - Githubissues

peppeocchi / php-cron-scheduler

PHP cron job scheduler

MIT License

808 stars 143 forks source link

Laravel 8 support #113

Closed timonschenzel closed 3 years ago

timonschenzel commented 3 years ago

Laravel 8 requires dragonmantank/cron-expression v3. So upgrading to Laravel 8 is not possible without this change.

coveralls commented 3 years ago

Coverage remained the same at 100.0% when pulling fee3f4ffbbd8397713592d3f9eb87c207b6c8126 on timonschenzel:patch-1 into fc19fd9d1ebe03f11820b05da744d97a2b5479d0 on peppeocchi:master.

peppeocchi commented 3 years ago

@timonschenzel it's interesting you're using this in Laravel instead of the built in Laravel Scheduler. I'm curious, any reason in particular? I'll have a look at this PR to see if it's backward compatible, or if I have to release a new major version, thanks!

timonschenzel commented 3 years ago

@peppeocchi We are running an "old" CodeIgniter project where we created a cron scheduler our self with this package. At some point with did introduce Laravel within this project and some parts are running on Laravel now. But other parts are still running on CodeIgniter (like our cron scheduler).

I hope it's possible to upgrade :)

timonschenzel commented 3 years ago

@peppeocchi Thanks for merging this PR! 😄 You didn't create a new release for this (I don't know if it's intended). Otherwise we will use dev-master.

peppeocchi commented 3 years ago

@timonschenzel just released v3.1, thanks for the contribution!