search

pepperoni21 / ollama-rs

A Rust library allowing to interact with the Ollama API.
MIT License
367 stars 47 forks source link

Fix return type for generate function #16

Closed SimonCW closed 5 months ago

SimonCW commented 5 months ago

As discussed here https://github.com/pepperoni21/ollama-rs/issues/15, this fixes the generate function.

The relevant test passes, but I wasn't able to run all tests since I'm missing the Modelfile.example files. I want to create a setup function to create all necessary files (if not existent) first. What do you think?

pepperoni21 commented 5 months ago

As discussed here #15, this fixes the generate function.

The relevant test passes, but I wasn't able to run all tests since I'm missing the Modelfile.example files. I want to create a setup function to create all necessary files (if not existent) first. What do you think?

Thanks for your contribution! Concerning the setup function, that's an interesting idea but I don't think it's necessary as a change is very unlikely to require all tests to be run, and some tests require a whole model to be downloaded (image support for example).