search

pepsico-ecommerce / snowflex

elixir snowflake client
Apache License 2.0
52 stars 10 forks source link

V1.0.0 fix logger deprecations #80

Closed kellyfelkins closed 8 months ago

kellyfelkins commented 8 months ago

I noticed deprecations warnings on Logger.warn.

kellyfelkins commented 8 months ago

I would add a note into the changelog because its covering an underlying deprecation that was already around if you were upgrading but LGTM

Good point. What was I thinking?!

kellyfelkins commented 8 months ago

We had a discussion about the v1.0.0 branch and how to handle changes to that branch.

https://pepsiecomm.slack.com/archives/C03SPDCC2FJ/p1709769218788049

This small change is consistent with other recent commits on v1.0.0, so I'm going to merge it.