search

perak / codemirror

CodeMirror editor for Meteor >= 1.0
27 stars 15 forks source link

Active Line Mode #11

Closed sangyoo91 closed 9 years ago

sangyoo91 commented 9 years ago

I would love to have this feature, and if it is already implemented, I must be missing it on how to use it here in meteor.

perak commented 9 years ago

@sangyoo91 Here we go - update your package and add styleActiveLine: true to code mirror options.

sangyoo91 commented 9 years ago

@perak Thank you for the fast response! However, I am not getting the active line highlighted after the update to 1.2.4 and adding styleActiveLine: true to this.

perak commented 9 years ago

@sangyoo91 do you have css style for .CodeMirror-activeline-background ?

sangyoo91 commented 9 years ago

@perak 

.CodeMirror-activeline-background {
  background: red;
}

This is what I have to test it. However, I don't even see the class in the tree of web inspector.

sangyoo91 commented 9 years ago

@perak Has this been figured out?

perak commented 9 years ago

Sorry dude, being super-busy with other things, I'l try tomorrow. In meantime, please check official codemirror example and see is there any .js file included which is not included in this package's package.js (try by installing package locally and include missing files (if any). If you find a solution just let me know, that will speed up the things.

@perak https://github.com/perak Has this been figured out?

— Reply to this email directly or view it on GitHub https://github.com/perak/codemirror/issues/11#issuecomment-126948062.

perak commented 9 years ago

Hey @sangyoo91

Excuse me for late answer: I just tried and it works for me (!?). Are you sure package is updated to 1.2.4?

And that you have:

{
    styleActiveLine: true
}

in editor options?

Screenshot is attached. works_for_me

sangyoo91 commented 9 years ago

@perak

I'm very sorry. I did meteor update but didn't check the package version afterwards because the console showed me that it updated to 1.2.4. However, I just double checked and it still remained as 1.2.3. I did a meteor add specifying the version and it worked. Thank you!!

perak commented 9 years ago

@sangyoo91 no problem. Glad it worked! Closing this issue.