perak / kitchen-site

Meteor Kitchen site source code
MIT License
282 stars 38 forks source link

Meteor-kitchen --example-invoices crashes while building sample invoice app #146

Open ferozearif opened 8 years ago

ferozearif commented 8 years ago

Hi,

I am using Meteor Kitchen v0.9.51 and it is crashing when I run meteor-kitchen --example-invoices. All the other examples ( --example-accounts, --example-admin, --example-dataview, --example-geiger, --example-ide, --example-iot, --example-markdowned, --example-markdowned, --example-minimal, --example-onepage, --example-photosharing, --example-semantic, --example-subpages, --example-upload) excepting a few (--example-human, --example-human-iot, and --example-plugins) seem to be working.

These ((--example-human, --example-human-iot, and --example-plugins) ) are failing gracefully but when I run meteor-kitchen --example-invoices, it crashes abruptly.

It seems to be crashing just after or while creating the "customers" collection. I am attaching a screenshot for your review. I was using ver 0.9.49 and I didn't face any issues. A day ago I upgraded to 0.9.51 and I have been facing these problems. I was using 0.9.49 to develop an application and I upgraded to 0.9.51 and made some changes to the application's json file and tried regenerating the files and meteor-kitchen started crashing. That's when I tried out the --example-invoice option and even that crashed.

I hope you will be able to fix the issue. I like your program and it is very useful for building prototypes. In case you need any additional information, kindly contact me.

Warm regards Feroze

image

perak commented 8 years ago

@ferozearif thanks for detailed review! :)

it doesnt crash under linux (I allways test all examples before uploading new version) so it must be some issue related to windows (or windows directory separator - backslash instead slash...). I 'll see what I can do later when I reach my computer.

ferozearif commented 8 years ago

Thank you for your prompt response Peter. I look forward to your resolution.

Warm regards Feroze On 4 Oct 2015 17:59, "Petar Korponaić" notifications@github.com wrote:

@ferozearif https://github.com/ferozearif thanks for detailed review! :)

it doesnt crash under linux (I allways test all examples before uploading new version) so it must be some issue related to windows (or windows directory separator - backslash instead slash...). I 'll see what I can do later when I reach my computer.

— Reply to this email directly or view it on GitHub https://github.com/perak/kitchen-site/issues/146#issuecomment-145331540.

perak commented 8 years ago

@ferozearif I just reach my computer. Are you using windows 7? (yeah sometimes kitchen behaves different with different versions of windows).

perak commented 8 years ago

@ferozearif I just built "example-invoices" under windows 7 and it passes normally.

As I can see from your screenshot, it looks like you built it with old version of meteor kitchen, and after upgrade you built it again with new version into same directory (and overwriting files).

Normally, it should work but... please try to clean-build app (delete directory, or build into another directory) and let me know what happens.

ferozearif commented 8 years ago

Hello Petar,

I am using 64 bit Windows 7.

Yes, you are right. Initially I did build with the older version of meteor kitchen and then after upgrade I tried building into the same directory.

After that I tried building the app into new directory. On the first try, the program crashed at the same point as before. Then I ran it one more time, building into the same directory and meteor-kitchen executed correctly and created all the files. I was then able to go into the directory and run meteor. There was a Unknown import error which got corrected automatically and then the application started up after which I was able to view the application at http://localhost:3000.

Below are a few screenshots of the above behaviour. I hope that these are helpful.

Warm regards Feroze

image image image image

perak commented 8 years ago

@ferozearif humm... I cannot reproduce that crash. I am using 32-bit win7 in virtual machine, but I don't think issue is related to 32/64bit. I'll try the same thing with other versions of windows too.

About initial "unknown import": it hapens only on a first run - imported file is automatically created by nemo64:bootstrap package on first run, but meteor reports missing file before package creates it. After package creates file, meteor restarts and everything is fine. It looks ugly but is normal behavior.

ferozearif commented 8 years ago

Hello Petar,

Thank you for investigating the issue and thanks for the clarification about the "unknown import". I understand that you are unable to reproduce the crash but it's happening on my machine. :( For now, I've started running Meteor-Kitchen on a Linux machine and am planning to copy the generated code to my Windows machine. I am kinda used to developing on Windows, hence I am adopting this solution for now. I hope that you will be able to identify the issue and fix it. It will definitely be helpful.

Nevertheless, thank you for your efforts. In case you need any additional information, please do not hesitate to contact me.

Warm regards Feroze

On Mon, Oct 5, 2015 at 2:18 PM, Petar Korponaić notifications@github.com wrote:

@ferozearif https://github.com/ferozearif humm... I cannot reproduce that crash. I am using 32-bit win7 in virtual machine, but I don't think issue is related to 32/64bit. I'll try the same thing with other versions of windows too.

About initial "unknown import": it hapens only on a first run - imported file is automatically created by nemo64:bootstrap package on first run, but meteor reports missing file before package creates it. After package creates file, meteor restarts and everything is fine. It looks ugly but is normal behavior.

— Reply to this email directly or view it on GitHub https://github.com/perak/kitchen-site/issues/146#issuecomment-145441099.

perak commented 8 years ago

@ferozearif I am curious on this issue - I'll try to reproduce and fix it.

People already reported "strange" (hard-to-reproduce) issues in windows environment.

It will be great if you can install fresh copy of windows in another (or virtual) machine and try running the same thing there - I am (almost) sure that issue will not appear.

Anyway, as you maybe saw - I am planning to open the CLI source code, and then it will be easier to catch bugs - for example in your case - compiling and running "kitchen" in debug mode will show us more info on what happens/what crashed.

Until then, the best I can is to try to reproduce the bug.

Thanks for bug report.

perak commented 8 years ago

@ferozearif I still can't reproduce this issue. Did you eventually found cause?

ferozearif commented 8 years ago

Hi Petar, I was in a hurry, so I built my prototype on Linux and on the Linux platform I didn't face any issues. I will check again on the windows version of meteor-kitchen in a day or two and then update you. Sorry about the delay. Warm regards Feroze Sent with SolMail App--------- Original Message --------- From: "Petar Korponaić" To: perak/kitchen-site Date: Wed Oct 14 16:14:17 GMT+08:00 2015 Subject: Re: [kitchen-site] Meteor-kitchen --example-invoices crashes while building sample invoice app (#146)

@ferozearif I still can't reproduce this issue. Did you eventually found cause?

—Reply to this email directly or view it on GitHub.

perak commented 8 years ago

Thanks @ferozearif .

No worries, I am just reviewing issues and trying to solve/close some :)