perawallet / pera-wallet

Source code for Pera Wallet, simply the best Algorand wallet.
https://perawallet.app
Other
178 stars 62 forks source link

Use Swift Package Manager? #37

Closed ivnsch closed 1 year ago

ivnsch commented 2 years ago

Has it been considered to migrate the iOS project to SPM? It's Apple's native dependency manager, simpler to configure, doesn't alter the project file / force to use a workspace, doesn't depend on Ruby, etc. And probably is less likely to have issues like these (new CocoaPods installation (1.11.2) on an Apple Silicon Mac):

Regular terminal:

$ pod install
Analyzing dependencies
Pre-downloading: `Macaroon` from `https://github.com/Hipo/macaroon.git`, tag `2.12.0`
/Library/Ruby/Gems/2.6.0/gems/ethon-0.15.0/lib/ethon/curls/classes.rb:36: [BUG] Illegal instruction at 0x0000000102a94000
ruby 2.6.8p205 (2021-07-07 revision 67951) [universal.arm64e-darwin21]

Rosetta configured terminal:

$ pod install
Analyzing dependencies
Pre-downloading: `Macaroon` from `https://github.com/Hipo/macaroon.git`, tag `2.12.0`
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require': dlopen(/Library/Ruby/Gems/2.6.0/gems/ffi-1.15.4/lib/ffi_c.bundle, 0x0009): tried: '/Library/Ruby/Gems/2.6.0/gems/ffi-1.15.4/lib/ffi_c.bundle' (mach-o file, but is an incompatible architecture (have 'arm64', need 'x86_64')), '/usr/lib/ffi_c.bundle' (no such file) - /Library/Ruby/Gems/2.6.0/gems/ffi-1.15.4/lib/ffi_c.bundle (LoadError)

(Edit: https://stackoverflow.com/a/65334677/930450 solves the installation issue)

taylanpince commented 2 years ago

@sakkaras Thoughts on this?

sakkaras commented 1 year ago

@taylanpince I don't remember from when, but we are already using SPM for a while.

taylanpince commented 1 year ago

Thanks for confirming!