search

perawallet / pera-wallet

Source code for Pera Wallet, simply the best Algorand wallet.
https://perawallet.app
Other
178 stars 62 forks source link

Report iOS/Android and version when connecting using the WalletConnect #41

Closed patrik7 closed 2 years ago

patrik7 commented 2 years ago

When WalletConnect is used to create session with the app, the app sends the peerMeta data back.

It would be incredibly useful, if it was possible find out what exactly wallet connect connected with, namely:

I can already see the apps, iOS vs. android, behaving differently, and I assume in the future it will not be always possible to keep the codes in sync.

As the developer of the other side of the communication, I would like to know what exactly is on the other side. Screenshot from 2021-11-26 13-20-15

mitsinsar commented 2 years ago

Hi Patrik! You are right, it would be nice to know as a dApp who the client is. But as far as I know, Official WalletConnect client accepts an object called Session.PeerMeta which only accepts fields below; description: String? icons: List<String>? name: String? url: String? Do you have any suggestions to send client meta to the dApp??

patrik7 commented 2 years ago

Such a fast reply! Thanks

The options are pretty limited, yes :/

At a minimum, the URL could point to the store: https://play.google.com/store/apps/details?id=com.algorand.android https://apps.apple.com/us/app/algorand-wallet/id1459898525

The version could be appended as: ?vesrion=1.23 to the URL

Regards

mitsinsar commented 2 years ago

Unfortunately this is not a good solution to solve this issue. Also store doesn't support version query.

WalletConnect v2 may solve this in the future.