perawallet / pera-wallet

Source code for Pera Wallet, simply the best Algorand wallet.
https://perawallet.app
Other
188 stars 60 forks source link

Transactions returned from WalletConnect encoded differently #44

Closed patrik7 closed 1 year ago

patrik7 commented 2 years ago

After the transactions are sent for user's signature thru the Wallet Connect and are signed, they come back:

It seems the iOS version returns the transactions as base64 encoded string While Android returns them as UInt8Arrays

Happens for regular Payment transactions.

You can easily convert from one to another, but it's inconsistent, and since you do not know against which version you connected to: https://github.com/algorand/algorand-wallet/issues/41

It's tedious to deal with.

I would vote to use the base64 encoding, as that's the same format transactions were submitted in.

taylanpince commented 2 years ago

@sakkaras @artizco Can you please review this?

yigitguler commented 1 year ago

This is fixed.