perawallet / pera-wallet

Source code for Pera Wallet, simply the best Algorand wallet.
https://perawallet.app
Other
178 stars 62 forks source link

intermittent appending of xnote in algorand transaction if specified in transaction URI scheme #90

Closed malimohub closed 11 months ago

malimohub commented 1 year ago

I provided url encoded XNOTE in Algorand transaction URI scheme as per https://developer.algorand.org/docs/get-details/transactions/payment_prompts/, as to prevent sender from modifying note after scanning QR code.

During testing, I scanned QR code and transaction request appeared. if I click "Next" button in wallet and then "Send" button the note is not included in transaction, however if i click "Show Note" and "Done", before hitting "Next" button and then hit "Send" the note is included in transaction.

taylanpince commented 1 year ago

@malimohub Thank you for this report. Can you please attach a sample QR code here?

malimohub commented 1 year ago

@taylanpince Thanks for the quick response, you can find sample QR code below. asset is on testnet

Screen Shot 2022-07-28 at 3 14 23 PM
taylanpince commented 1 year ago

Thank you so much. I was able to reproduce the issue and we are tracking this internally.

malimohub commented 1 year ago

@taylanpince any movement on this ? definitely a very helpful param if trying to associate blockchain transactions back to an internal transaction.

taylanpince commented 1 year ago

@malimohub Yes, this is being worked on. Fix will be up with one of our upcoming bugfix releases.

malimohub commented 1 year ago

any traction on this ticket @taylanpince ?

taylanpince commented 1 year ago

@malimohub Still in progress. I just prioritized it to be included in 5.4.1 release (ETA in September)

malimohub commented 1 year ago

@taylanpince Thanks for prioritizing this bug ticket. Just checking in on this bug fix / scheduled 5.4.1 release?

taylanpince commented 1 year ago

@malimohub Still in progress and scheduled for 5.4.1. We are a bit delayed with this but should be out this month.

taylanpince commented 1 year ago

@malimohub Apologies confirmed that this will be in 5.4.2

malimohub commented 1 year ago

@malimohub Apologies confirmed that this will be in 5.4.2

Sweet thanks man, will check it out this week. Appreciate you guys working to get this fix pushed out

malimohub commented 1 year ago

@taylanpince did this make it to 5.4.2 ? The xnote still does not seem to get appended to transaction. I see the code was tagged at 5.4.2, was this deployed?

Thanks

taylanpince commented 1 year ago

@malimohub Apologies for this, our release planning didn't go as planned here 😅 We had to prioritize some other issues that had to be released earlier, and this one got pushed out. We are going to get the 5.5.0 feature release out in a few days, then we will get 5.5.1 out within 2 weeks which will include this fix (and many others).

malimohub commented 1 year ago

ahh i see @taylanpince , is there a work around?

taylanpince commented 1 year ago

@malimohub AFAIK there is no workaround. However the fix is coming very soon.

yigitguler commented 11 months ago

The fix is live.