search

perawallet / pera-wallet

Source code for Pera Wallet, simply the best Algorand wallet.
https://perawallet.app
Other
190 stars 60 forks source link

PeraWallet does not accept NOTE field for optin URI scanned via QRCode #98

Open emg110 opened 2 years ago

emg110 commented 2 years ago

Based on Algorand URI schema NOTE field can be added to any transaction URI and therefore it can be included in the resulting QRCode from that URI as well. Perawallet's code checks to see it's null and then accepts it otherwise triggers Error: Malformed URI.... I have checked the code and it assertively checks the Note field in the scanned QRcode URI to be null!!! Given the scenarios during which some data acquisition can be made and transferred using the Note field, I suggest fixing it to accept Note field for Optin URI schemas, please.

emg110 commented 1 year ago

any updates on this one guys?

yigitguler commented 1 year ago

Hi

We tried to regenerate this issue, but seems to be working fine. Could you please provide an example URL that doesn't work?

DingusMungus commented 2 months ago

Your own generator doesn't even work! How exactly did you test it?

Adding a note field to a request for "Receive Algorand" makes the QR and link fail in the android v5.10.12 wallet.

Issue 1: QR codes requesting algo with a note fail (links too) See: https://perawallet.app/qr-code-generator/result?reason=Receive+Algo&address=SIP2GKX3Z6XA6C44BDD6J2WWWLK6UJF3TR2ZFUIFIJBLNS4FZAKKTADUQU&amount=0.001&note=test

Issue 2: xnote field is editable, but is intended to be locked

Additional information:

Device Model or Browser Note20 Ultra Device OS & Version Android 13 Pera App Version 5.10.12 Public Wallet Address SIP2GKX3Z6XA6C44BDD6J2WWWLK6UJF3TR2ZFUIFIJBLNS4FZAKKTADUQU