search

perbrage / sectoralarm

Sector Alarm Node.js Library
MIT License
23 stars 8 forks source link

Adding functionality to arm/disarm annex #2

Closed frli4797 closed 5 years ago

frli4797 commented 6 years ago

Utilizing Sectoralarm API fuction to arm and disarm annex buildings, such as garage or outhouses. site.js now also returns annex events from history() and annex status from status(). Trying to be true to the format and had the parser do camel case for events/status.

Added some very basic unit testing of new features. Could possibly improve somewhat.

perbrage commented 6 years ago

Hi!

Nice addition! I will check this out when I have some more time, hopefully next week!

//Per Brage

10 juli 2018 kl. 23:26 skrev frli4797 notifications@github.com<mailto:notifications@github.com>:

Utilizing Sectoralarm API fuction to arm and disarm annex buildings, such as garage or outhouses. site.js now also returns annex events from history() and annex status from status(). Trying to be true to the format and had the parser do camel case for events/status.

Added some very basic unit testing of new features. Could possibly improve somewhat.

You can view, comment on, or merge this pull request online at:

https://github.com/perbrage/sectoralarm/pull/2

Commit Summary

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/perbrage/sectoralarm/pull/2, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AA-YRBxQrJEswWTCSk3ADHmjFkaGaRXXks5uFRwQgaJpZM4VKJhN.

perbrage commented 6 years ago

Hi again! Been looking a bit at this, and what is the difference between armingAnnex and a partialArm? I figure it is the same thing?

frli4797 commented 6 years ago

Partial arm is just the door/windows (no movement detection). When you have partially armed you can still be in you home as apart from fully armed.

Annex armed is any additional building, like a garage, annex or outhouse. In my case, my garage. Annexes are (almost) completely separated from the rest of the installation.

Best regards, /Fredrik

tors 9 aug. 2018 kl. 14:36 skrev Per Brage notifications@github.com:

Hi again! Been looking a bit at this, and what is the difference between armingAnnex and a partialArm? I figure it is the same thing?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/perbrage/sectoralarm/pull/2#issuecomment-411742176, or mute the thread https://github.com/notifications/unsubscribe-auth/AFg1qPtu9H-sa__ZU4p7gLhsRgngyitzks5uPCzSgaJpZM4VKJhN .

perbrage commented 6 years ago

That doesn't sound completely accurate, or perhaps that can be configured by sector alarm per site which confuses me a bit. But PartialArm, as it works here, is completely arming a zone like ground floor including motion detectors, while not arming the second floor.

Even so, the annex could be a separate building, got it. My problem is however I don't have an annex configuration as everything that needs arming is armed with arm, so I can't really test this feature after I merge it. :(