Closed frli4797 closed 5 years ago
Merging this in for now, but won't make a release out of it yet. Let's see if we can all the topics in one bang.
I’d really like a unit test for the notifications but struggling a bit with it. However other than that I think I’m code complete with that PR.
ons 31 okt. 2018 kl. 19:05 skrev Per Brage notifications@github.com:
Merging this in for now, but won't make a release out of it yet. Let's see if we can all the topics in one bang.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/perbrage/sectoralarm/pull/5#issuecomment-434785257, or mute the thread https://github.com/notifications/unsubscribe-auth/AFg1qJY9A_4z_N3lyKnUjdYNEwL3rlq6ks5uqeZlgaJpZM4YClNx .
Did you manage to create a PR for this part?
Except the unit test. Maybe I can submit the pr without it for now. In that case within a couple of days.
tis 13 nov. 2018 kl. 16:29 skrev Per Brage notifications@github.com:
Did you manage to create a PR for this part?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/perbrage/sectoralarm/pull/5#issuecomment-438307136, or mute the thread https://github.com/notifications/unsubscribe-auth/AFg1qJaKBN48HGxxCOjNRnS1SlRLMp4Wks5uuuU9gaJpZM4YClNx .
Ok, no worries! I'm not in a rush :)
Just rectifying some names as discussed.