search

perbrage / sectoralarm

Sector Alarm Node.js Library
MIT License
23 stars 8 forks source link

eslint issues #9

Closed frli4797 closed 2 years ago

frli4797 commented 5 years ago

Found a few minor things with eslint. Like unused imports and vars, double quotes, indents and similar stuff.

PR or leave?

perbrage commented 5 years ago

A PR those things would be welcomed. Just make sure you have the latest code I pushed today that resolved the info, status and locks issues. I also upgraded a few third library packages for security purposes.

frli4797 commented 5 years ago

I'll push the eslint config as well. You can chose to have it in .gitignore as you please.

perbrage commented 5 years ago

Hi,

Seems I did not pull this one. Can you check with the latest code if there are any conflicts?

perbrage commented 4 years ago

I closed the pull request for these issues, cause there were conflicts after doing to much on my end. If you feel you want to try again, go ahead. But I am adding new features in the near future as well, so you might want to wait a bit.

Sorry