percivalalb / DoggyTalents

Train your dogs!
GNU Lesser General Public License v3.0
57 stars 48 forks source link

[All versions MAY affected!] Longtime bug with the command emblem when selecting a target #31

Closed NovaViper closed 7 years ago

NovaViper commented 7 years ago

There's this bug that has been around the mod for a long time, and I had actually forgotten to report it to you <_>. The bug is when you right click with the command emblem (which fires that snowball to select a target), the ball actually hits the player/owner and causes the dog to attack the owner instead of the intended target. This is especially bad if the dog's attack talents are maxed.

As far as I know now, MC 1.12 and 1.11.2 are affected. However... I do remember seeing this bug back in MC 1.10.2. Since this bug is very easy one to miss if you don't use the tactical mode! I only spotted it this time because I was using the tactical mode. And with that in mind.. it may be even affecting versions before MC 1.10.2

percivalalb commented 7 years ago

I too had just noticed this, already fixed. Working on bringing MC 1.10 and MC 1.11 to the same content as MC 1.12.

percivalalb commented 7 years ago

I am starting to work on system where I can code simultaneously for version 1.9.4 - 1.12 because the majority of the code is very similar for the different versions. I will be making it so that it only loads some classes they are needed for specific versions.

NovaViper commented 7 years ago

That's awesome! You should make a library mod for your code. When I was working on TetraCraft (but however had to cease development V_V), I had created a library where I had the major stuff (i.e. Item registries, resource registries, etc.) siting in the library and had my mods pulling from there