search

percivalalb / DoggyTalents

Train your dogs!
GNU Lesser General Public License v3.0
55 stars 48 forks source link

Operator cannot join server #427

Closed hexagonelle closed 6 months ago

hexagonelle commented 1 year ago

Environment And Mod Information:

Logs

Not available

Issue Description:

If a user is opped on a server with Doggy Talents and attempts to connect, the user is immediately disconnected. If a user is on the server, and then made op, the server disconnects that user with the error "Internal Exception: io.netty.handler.codec.DecoderException: java.lang.IndexOutOfBoundsException: readerIndex(17789) + length(1) exceeds writerIndex(17789): UnpooledHeapByteBuf(ridx:17789, widx: 17789, cap: 17789/17789)

Steps to reproduce:

  1. Create a server running Forge 43.1.65, with Doggy Talents 1.19.2.2.6.5 as the the only mod.
  2. Connect to the server.
  3. Run the command /op [username] in the server, replacing [username] with your username.
  4. You will be kicked from the server.

Additional Information:

doggytalents commented 1 year ago

Have the excact same issue in the same minecraft version, just with essential world hosting instead of a forge server.

iam-danless commented 1 year ago

Same here. Forge 1.19.2-43.2.0 DoggyTalents 1.19.2-2.6.5

percivalalb commented 1 year ago

Thanks for reporting, unfortunately it's going to be a few weeks before I can take a look. Thanks for your patience in advance.

wailhorn commented 1 year ago

Same here Forge 1.19.2-43.2.0 DoggyTalents_2.6.5_1.19.2

Feldor-Lex commented 1 year ago

Same issue here, spent the night trying to find the culprit in my pack. Forge 1.19.2 43.2.1 DoggyTalents-1.19.2-2.6.5.jar

Please consider putting a warning on the curseforge page so people are aware of this on the 1.19.2 version.

percivalalb commented 1 year ago

After, a bit of small bit of digging I discovered that I was registering COMMAND_ARGUMENT_TYPES incorrect. From 1.18 to 1.19 they now use a proper registry: https://forums.minecraftforge.net/topic/112177-argumenttypes-in-minecraft-119/

After correcting that issue, I can not reproduce this issue anymore. It seems linked, I will release this fix and close if no one else complains.

percivalalb commented 1 year ago

Should be fixed in "1.19.2-2.6.10"