TextView already has an append method. Maybe the whole method isn't even required?

percolate / caffeine

Speed up your Android development

BSD 3-Clause "New" or "Revised" License

414 stars 39 forks source link

TextView already has an append method. Maybe the whole method isn't even required? #1

Closed MrManny closed 9 years ago

MrManny commented 10 years ago

TextView already has an append method since API level 1. I don't quite see the benefit of using getText+setText here.

VicV commented 10 years ago

Dont see the benefit of this method at all considering its so simple to begin with

brentwatson commented 10 years ago

Good catch @MrManny. Go ahead and remove appendText() in the PR and I'll merge it.

MrManny commented 10 years ago

To be fair, if anyone happened to use the method in its current form, it might be best to keep it around and annotate it as obsolete to avoid breaking someone else's code.

brentwatson commented 10 years ago

We're not at a full 1.0 release yet, so I'm ok with breaking contract for something this minor.