Updated DialogUtils to only allow one dialog to be shown.

percolate / caffeine

Speed up your Android development

BSD 3-Clause "New" or "Revised" License

414 stars 39 forks source link

Updated DialogUtils to only allow one dialog to be shown. #11

Closed superuserdid closed 9 years ago

superuserdid commented 9 years ago

What Changed

Improvements on performance. DialogUtils class now only allows one dialog to be shown.

Review

[ ] @brentwatson
[ ] @msya

brentwatson commented 9 years ago

@luxnova please merge master.

brentwatson commented 9 years ago

LGTM.

@msya Want to do a quick review of these changes too?

msya commented 9 years ago

@luxnova @brentwatson Should we add a section in the README for upgrading to the new version that will have this change? In section, we could state that the method quickDialog will require an additional param?

msya commented 9 years ago

Would you update the DialogUtils example in README?

superuserdid commented 9 years ago

@brentwatson @msya so green light to touch the readme and add these changes?

brentwatson commented 9 years ago

Yup. Edit away!