percolatestudio / atmosphere

Atmosphere - Meteor Packages
https://atmospherejs.com
59 stars 4 forks source link

100% height layout #292

Open jlukic opened 10 years ago

jlukic commented 10 years ago

It looks like the site wasnt built with sticky footers, so on short pages, the content doesn't fill the entire screen correctly.

For example here

A simple solution would be

.applicationLayout > .content {
  display: flex;
  min-height: 100vh;
  flex-direction: column;
}
.applicationLayout > .content > .page {
  flex: 1;
}

You can see this technique used here

dandv commented 9 years ago

:+1: for using the flex layout!

domyen commented 9 years ago

Thanks for the detailed suggestion @jlukic! The flexbox solution unfortunately doesn't play nice with our markup pattern which uses absolute positioning. We'll probably revisit this in the future so I'll leave it open, I don't think this can work unless we refactor our layout. :(