search

percolatestudio / meteor-google-api

A simple API encapsulating some common patterns regarding Google's APIs
https://atmospherejs.com/percolate/google-api
MIT License
48 stars 30 forks source link

create a copy of options before modifying to prevent callback problems #24

Closed hexsprite closed 9 years ago

hexsprite commented 9 years ago

discovered a bug that occurred because the delete options.user was modifying options that were needed by the callback.

this fixes the problem.

tmeasday commented 9 years ago

Could we just do _.extend({}, options) and hit both cases?

hexsprite commented 9 years ago

cool, I changed it...

tmeasday commented 9 years ago

Looks great, thanks Jordan!