search

percolatestudio / meteor-google-api

A simple API encapsulating some common patterns regarding Google's APIs
https://atmospherejs.com/percolate/google-api
MIT License
48 stars 30 forks source link

Update to new Meteor Google Oauth package name #41

Closed allenfuller closed 7 years ago

allenfuller commented 7 years ago

Meteor recently updated their package naming from google to google-oauth which resulted in an error per this issue. This update resolves that issue.

allenfuller commented 7 years ago

Now that there's a new maintainer, I wanted to check in and see if it would be possible to get this update merged. Thanks!

ro6 commented 7 years ago

@tmeasday I'd like to merge this PR, but I'm not seeing that I have permissions to.

tmeasday commented 7 years ago

Hi @ro6 -- it says it's still awaiting your response to the invitation to be a collaborator. Try here: https://github.com/percolatestudio/meteor-google-api/invitations

ro6 commented 7 years ago

@tmeasday Thanks for the guidance, I missed the email notification.

@allenfuller Thanks for the PR. This commit: https://github.com/percolatestudio/meteor-google-api/commit/ad1bfb43fc3d54e660d7b11ba1233ca6afea2d21 has the equivalent of the fix in this PR, so I'm closing. I would have preferred merging yours in and building off that, but had already made the change myself. My bad!

allenfuller commented 7 years ago

Oh, no worries @ro6, just glad to see it updated. Thanks for taking on this project!