percolatestudio / meteor-google-api

A simple API encapsulating some common patterns regarding Google's APIs
https://atmospherejs.com/percolate/google-api
MIT License
48 stars 30 forks source link

Cosmetic changes and expanded description #5

Closed dandv closed 9 years ago

zol commented 9 years ago

@dandv Thanks for submitting this. Could you please resubmit a PR with just the readme and typo fixes included (without the function () code reformatting. This is not our coding style and I see no reason to make this one package inconsistent with the rest of our code.

dandv commented 9 years ago

Hey Zoltan, I'm sorry but I don't have time to revisit this. IMO Meteor packages should adopt the official Meteor style guide.

zol commented 9 years ago

No worries. I disagree with your assertion though. Package authors should be free to choose whatever style guide (or language) they want to write their packages in. We write javascript for more platforms than just Meteor and prefer to adhere to Google's javascript style guide across all of our code.

Ironically, Meteor core isn't fully compliant with their own style guide either.