Include the migration itself as an argument to migration callbacks

percolatestudio / meteor-migrations

Simple migration system for Meteor

https://atmospherejs.com/percolate/migrations

MIT License

245 stars 58 forks source link

Include the migration itself as an argument to migration callbacks #35

Closed JamesMGreene closed 9 years ago

JamesMGreene commented 9 years ago

Include the migration itself as an argument to migration callbacks.

Fixes #34.

More subtle effects:

The migration objects are now frozen immediately after being added.
The this context of the migration callbacks will now default to being the migration itself.

Documentation of this new enhancement has been omitted as per @zol's request in #34.

zol commented 9 years ago

Thanks @JamesMGreene , sorry it took me so long to take a look. The PR is great but I'd ask for one small change - please simplify the test down to its essence. There is no need to test so many cases for such a basic change. Just verifying that the parameter is passed in once will suffice.

JamesMGreene commented 9 years ago

If you say so. :stuck_out_tongue_winking_eye:

JamesMGreene commented 9 years ago

Updated with simplified test.

zol commented 9 years ago

Thanks for your contribution @JamesMGreene - just released this.