Closed boxofrox closed 9 years ago
@tmeasday, fyi, will publish 0.6.0 if the #32 crowd find this PR acceptable.
Sounds good to me @boxofrox
On Wed, 5 Aug 2015 at 09:05 boxofrox notifications@github.com wrote:
@tmeasday https://github.com/tmeasday, fyi, will publish 0.6.0 if the
32 https://github.com/percolatestudio/publish-counts/issues/32 crowd
find this PR acceptable.
— Reply to this email directly or view it on GitHub https://github.com/percolatestudio/publish-counts/pull/56#issuecomment-127790596 .
This approach is fine with me.
I can't find anything obviously wrong in the code :+1:
Works for me too, code looks good :+1:
Release 0.6.0 published on atmospherejs.
Allow users to test whether a count is published before reading the count.
Why a new function? I subscribe to the school of thought that a return value should have one meaning. Counts.get() only returns an integer representing number of docs, fields, or lengths counted. If no count is published, then nothing is counted and zero is a valid result.
Fixes #32