percona / percona-everest-cli

Apache License 2.0
6 stars 5 forks source link

EVEREST-702 Generate token only once during the installation #240

Closed gen1us2k closed 11 months ago

gen1us2k commented 11 months ago

CHANGE DESCRIPTION

Problem: EVEREST-702

Short explanation of the problem.

The main focus of the PR is to fix the generation of the token and make it only once during the installation. Since it's tightly coupled with the monitoring feature we discussed with @recharte I'll separate and move monitoring provisioning to the separate command and open PR with the improvements in the upcoming PR that will have validations for a password, everest endpoint configuration, and everything else.

This PR is to unblock both of us to work on the different features of the CLI Related pull requests

Cause: Short explanation of the root cause of the issue if applicable.

Solution: Short explanation of the solution we are providing with this PR.

CHECKLIST

Jira

Tests

codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b6a237d) 5.36% compared to head (33c8cc6) 4.94%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #240 +/- ## ======================================== - Coverage 5.36% 4.94% -0.42% ======================================== Files 13 12 -1 Lines 2889 2487 -402 ======================================== - Hits 155 123 -32 + Misses 2707 2339 -368 + Partials 27 25 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.