search

percona / percona-helm-charts

Collection of Helm charts for Percona Kubernetes Operators.
https://www.percona.com/software/percona-kubernetes-operators
Other
110 stars 151 forks source link

K8SPSMDB-1104 - add `annotations` value #331

Closed alex-souslik-hs closed 1 month ago

alex-souslik-hs commented 1 month ago

Add annotations value to allow custom annotations on the PerconaServerMongoDB resource.

cshiv commented 1 month ago

The ability to modify is always good.LGTM. @tplavcic Do you see any added value in having the below default annotation? Can it be removed?

  kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"psmdb.percona.com/v1","kind":"PerconaServerMongoDB"}
alex-souslik-hs commented 1 month ago

@cshiv @tplavcic if it can be removed entirely that'd be even better, it causes issues in Argo CD for example.

tplavcic commented 1 month ago

@alex-souslik-hs I cannot recall why this custom annotation was added. Please remove it in your PR and we will try to re-check it before merging your PR. Thanks for contribution!

alex-souslik-hs commented 1 month ago

@tplavcic any update?

tplavcic commented 1 month ago

@alex-souslik-hs The update is that it is merged! ;) Thank you very much for the contribution!