search

percona / percona-postgresql-operator

Percona Operator for PostgreSQL
https://www.percona.com/doc/kubernetes-operator-for-postgresql/index.html
Apache License 2.0
297 stars 54 forks source link

Cannot add custom labels for PostgreSQL metrics sent to PMM #691

Open konoox opened 8 months ago

konoox commented 8 months ago

Proposal

As far as I know, the CR definition of Percona PostgreSQL cluster does not provide any configuration attribute to add custom labels to the metrics sent to the PMM server from pmm-client containers. This is possible with Percona MongoDB clusters using spec.pmm.mongodParams and spec.pmm.mongosParams, but also with Percona XtraDB clusters using spec.pmm.pxcParams and spec.proxysqlParams.

Use-Case

The additional flags, in my case custom labels, are added to the "pmm-admin add" options through the PMM_ADMIN_CUSTOM_PARAMS environment variable in the prerun script :

Psmdb definition :

kind: PerconaServerMongoDB … spec: pmm: mongodParams: --custom-labels=namespace=my-namespace

Mongo pod definition :

It would be a great feature to implement this for the Percona PostgreSQL operator as well !

Is this a feature you are interested in implementing yourself?

No

Anything else?

No response

hors commented 1 month ago

Hi @konoox, I have created the jira task https://perconadev.atlassian.net/browse/K8SPG-604 to add it for PG operator. I hope we will add in in PGO v2.7.0. Thank you.