search

percona / percona-xtradb-cluster-operator

Percona Operator for MySQL based on Percona XtraDB Cluster
https://www.percona.com/doc/kubernetes-operator-for-pxc/index.html
Apache License 2.0
510 stars 184 forks source link

copy_files_xbcloud bug Quotation mark error #1727

Open louishot opened 3 weeks ago

louishot commented 3 weeks ago

https://github.com/percona/percona-xtradb-cluster-operator/blob/9a4f3dd57db0e9e75894d687cf2a33a91c9b0088/deploy/backup/copy-backup.sh#L188

env -i "${CREDENTIALS} ${xbcloud} get ${backup_path} --parallel=10" 1>"$dest_dir/xtrabackup.stream" 2>"$dest_dir/transfer.log"

it should be env -i ${CREDENTIALS} "${xbcloud} get ${backup_path} --parallel=10" 1>"$dest_dir/xtrabackup.stream" 2>"$dest_dir/transfer.log"

louishot commented 3 weeks ago

It writes the command as a string to xtrabackup.stream

hors commented 3 weeks ago

hi @louishot, please create PR :)