percona / pg_stat_monitor

Query Performance Monitoring Tool for PostgreSQL
https://docs.percona.com/pg-stat-monitor/
Other
466 stars 59 forks source link

Fix partition_prune testcase #440

Closed artemgavrilov closed 5 months ago

artemgavrilov commented 5 months ago

Fixes https://github.com/percona/pg_stat_monitor/issues/423

compute_query_id parameter has special value regress that allows pg_stat_monitor to have query identifier but hides it in EXPLAINs to let regression testing pass.

https://www.postgresql.org/docs/current/runtime-config-statistics.html#GUC-COMPUTE-QUERY-ID

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.56%. Comparing base (3d84610) to head (00bc98b). Report is 4 commits behind head on main.

:exclamation: Current head 00bc98b differs from pull request most recent head 05f5e2d. Consider uploading reports for the commit 05f5e2d to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #440 +/- ## ======================================= Coverage 90.55% 90.56% ======================================= Files 3 3 Lines 1271 1272 +1 Branches 35 35 ======================================= + Hits 1151 1152 +1 Misses 98 98 Partials 22 22 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Naeem-Akhter commented 5 months ago

@artemgavrilov

Any reason that in this PR we have this setting only for postgresql-14-build & postgresql-15-build ('compute_query_id = regress). But not for postgresql-16-build where it is still (compute_query_id = off)? Am i missing something? :)

artemgavrilov commented 5 months ago

@artemgavrilov

Any reason that in this PR we have this setting only for postgresql-14-build & postgresql-15-build ('compute_query_id = regress). But not for postgresql-16-build where it is still (compute_query_id = off)? Am i missing something? :)

Mmm, all 3 (14/15/16) workflows were edited. Screenshot 2024-04-09 at 13 58 48

Naeem-Akhter commented 5 months ago

@artemgavrilov Any reason that in this PR we have this setting only for postgresql-14-build & postgresql-15-build ('compute_query_id = regress). But not for postgresql-16-build where it is still (compute_query_id = off)? Am i missing something? :)

Mmm, all 3 (14/15/16) workflows were edited. Screenshot 2024-04-09 at 13 58 48

Then I guess, somehow GH was showing me wrong diff of changes. But change is reflected in your working branch. :)

Thanks!