Closed artemgavrilov closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.56%. Comparing base (
3d84610
) to head (00bc98b
). Report is 4 commits behind head on main.:exclamation: Current head 00bc98b differs from pull request most recent head 05f5e2d. Consider uploading reports for the commit 05f5e2d to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@artemgavrilov
Any reason that in this PR we have this setting only for postgresql-14-build & postgresql-15-build ('compute_query_id = regress). But not for postgresql-16-build where it is still (compute_query_id = off)? Am i missing something? :)
@artemgavrilov
Any reason that in this PR we have this setting only for postgresql-14-build & postgresql-15-build ('compute_query_id = regress). But not for postgresql-16-build where it is still (compute_query_id = off)? Am i missing something? :)
Mmm, all 3 (14/15/16) workflows were edited.
@artemgavrilov Any reason that in this PR we have this setting only for postgresql-14-build & postgresql-15-build ('compute_query_id = regress). But not for postgresql-16-build where it is still (compute_query_id = off)? Am i missing something? :)
Mmm, all 3 (14/15/16) workflows were edited.
Then I guess, somehow GH was showing me wrong diff of changes. But change is reflected in your working branch. :)
Thanks!
Fixes https://github.com/percona/pg_stat_monitor/issues/423
compute_query_id
parameter has special valueregress
that allowspg_stat_monitor
to have query identifier but hides it inEXPLAIN
s to let regression testing pass.https://www.postgresql.org/docs/current/runtime-config-statistics.html#GUC-COMPUTE-QUERY-ID