Percy is not recognizing currency formatting from 1.19.2 onwards

[blv-gustavomancuzo]

The problem

It seems like Percy is not being able to handle currency formatting correctly from 1.19.2 onwards, the issue is still occurring in 1.24.0.

Screenshots from Percy build:

Before 1.19.2:

After 1.19.2:

Environment

• Node version: 16.17
• @percy/cli version: 1.19.2 (still happening in 1.24.0)
• Version of Percy SDK you’re using: N/A
• OS version: MacOS Ventura 13.3
• Type of shell command-line [interface]: bash

Details

We are currently using @percy/cypress with the cy.percySnapshot command for our visual tests.

Code to reproduce issue

Method responsible for formatting the currency:

export const formatCurrency = (
  value: number | string = 0,
  currency: Currency = CURRENCIES.COP.VALUE
) => {
  const currencyFormatOptions = {
    currency,
    style: 'currency'
  }

  const parsedValue = parseFloat(value.toString())

  if (isNaN(parsedValue)) throw 'Value must be a valid number'

  const currencyValue = parsedValue.toLocaleString(
    CURRENCIES[currency].LOCALE,
    currencyFormatOptions
  )

  const regex = /([\d,.]+)/
  const unit = currencyValue.replace(regex, '')
  const amount = currencyValue.match(regex)?.[0]
  const amountPosition = currencyValue.match(regex)?.index

  return {
    currencyValue,
    splitCurrency: {
      ...(!amountPosition && { amount }),
      unit,
      ...(amountPosition && { amount })
    }
  }

[samarsault]

Can you share full end to end reproducible example?

[blv-gustavomancuzo]

Hey @samarsault, sure 😃

You can use this repo to reproduce the issue. On the README file you have the instructions on how to do it.

[github-actions[bot]]

This issue is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[shahidk8]

The issue is fixed in versions 1.24.2 onwards. Please update to latest release of percy/cli.