search

percy / cli

The Percy CLI is used to interact with, and upload snapshots to, percy.io via the command line.
https://docs.percy.io/docs/cli-overview
70 stars 43 forks source link

Adding check for correct SDK for percy product #1522

Closed rishigupta1599 closed 8 months ago

rishigupta1599 commented 8 months ago

Added validation for the case where the correct token and cli flow is used but sdk used is wrong. For exp: -> App Percy Token is used and cli server is also started using app:exec which will create correct App Percy Build but as percy_screenshot is common in both App Percy and Percy on Automate it can be possible to trigger percy_screenshot using Automate SDK which should not be the case ideally.

We are relying on build type and the endpoint called to determine which SDK would have been used and in which build

chinmay-browserstack commented 8 months ago

So we already have checks in all SDK's if command called and projectType is same. if it's not same it should throw error. so this might not be required.