percy / cli

The Percy CLI is used to interact with, and upload snapshots to, percy.io via the command line.
https://docs.percy.io/docs/cli-overview
71 stars 45 forks source link

PERCY_POSTINSTALL_BROWSER set to "0" or "false" should not trigger browser download #1687

Closed wojtekmaj closed 1 month ago

wojtekmaj commented 3 months ago

The problem

Briefly describe the issue you are experiencing (or the feature you want to see added to Percy). Tell us what you were trying to do and what happened instead. Remember, this is not a place to ask questions. For that, go to https://github.com/percy/cli/discussions/new

Environment

Details

If necessary, describe the problem you have been experiencing in more detail.

Debug logs

If you are reporting a bug, always include logs! Give the "Debugging SDKs" document a quick read for how to gather logs

Please do not trim or edit these logs, often times there are hints in the full logs that help debug what is going on.

Code to reproduce issue

Given the nature of testing/environment bugs, it’s best to try and isolate the issue in a reproducible repo. This will make it much easier for us to diagnose and fix.

ninadbstack commented 2 months ago

I have added a fix pr for this, would be merged and released in next CLI release

prklm10 commented 1 month ago

This was fixed in v1.29.3 . Closing this.