search

percy / percy-agent

[Deprecated in favor of `@percy/cli`] An agent process for integrating with Percy.
https://percy.io
MIT License
22 stars 25 forks source link

M1 Apple Silicon support requires a newer version of puppeteer dependency #635

Closed joshuacronemeyer closed 3 years ago

joshuacronemeyer commented 3 years ago

Percy agent depends on a very old version of puppeteer. If you're building on a newer version of node with native apple silicon support (i recently tried to upgrade to node 16 on ARM) puppeteer needs to be updated so that it can build.

Here is the error I get.

Exit code: 1
Command: node install.js
Arguments:
Directory: ~/myproject/node_modules/puppeteer
Output:
The chromium binary is not available for arm64:
If you are on Ubuntu, you can install with:

 apt-get install chromium-browser

~/myproject/node_modules/puppeteer/lib/cjs/puppeteer/node/BrowserFetcher.js:112
            throw new Error();
            ^

here is a puppeteer issue that resolves this issue in their newer releases. https://github.com/puppeteer/puppeteer/issues/6622

wwilsman commented 3 years ago

Hi @joshuacronemeyer! Percy agent is actually deprecated and will be made official very soon once the last few SDKs have been updated to work with the new Percy CLI. Here are the migration docs: https://docs.percy.io/docs/migrating-to-percy-cli

I don't believe this issue exists in the new CLI since it no longer depends on Puppeteer. But if you do run into any issues with the CLI, feel free to open an issue over there!