percy / percy-agent

[Deprecated in favor of `@percy/cli`] An agent process for integrating with Percy.
https://percy.io
MIT License
22 stars 25 forks source link

fix: Lock colors.js to prevent infinite loop #646

Closed convenient closed 2 years ago

convenient commented 2 years ago

It seems that the lock file has it at 1.4.0 from this commit https://github.com/percy/percy-agent/commit/27127097c8b821fb175c9c8e2e49e31f5a79284c#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2deR2876

The later versions of colors have an infinite loop added, see references below

References

Locking this to a known good version should give us capability back while migrations to the newer SDK are still underway

Robdel12 commented 2 years ago

Hey @convenient! I'll give a shot releasing this. But this project has been inactive for a year now, so I can't promise it'll be able to release or new bugs won't be introduced.

I super strongly suggest upgrading, there are bugs that you currently have you probably don't know about. Ideally, upgrading should be fairly straight forward, especially with @percy/migrate: https://docs.percy.io/docs/migrating-to-percy-cli (but I know, software always has gremlins)

convenient commented 2 years ago

@Robdel12 thanks! Yeah this is a stop gap for some projects running an old version of node that are in the process of being upgraded.

Those older node versions don't seem to play well with the new SDK so we were using this to keep us going in the meantime.

If we can stop this looping we'll be able to continue using Percy while we work out the migration process and the additional dependencies on our side

convenient commented 2 years ago

@Robdel12 🙌 Thank you so much buddy. Real life saver on this one 😅

This should keep us going while the upgrades are in flight

Yesterday

$ npx percy exec -- true | head -3
LIBERTY LIBERTY LIBERTY
LIBERTY LIBERTY LIBERTY
LIBERTY LIBERTY LIBERTY

Today

$ npx percy exec -- true | head -3
 ›   Warning: Skipping visual tests. PERCY_TOKEN was not provided.