search

percy / percy-capybara

Visual testing for Capybara with Percy.
https://docs.percy.io/docs/capybara
MIT License
45 stars 23 forks source link

Calling Percy.snapshot without a javascript driver silently does nothing #134

Closed MarkyMarkMcDonald closed 3 years ago

MarkyMarkMcDonald commented 4 years ago

I wasted some time trying to figure out why my test wasn't generating any snapshots - it was because my test was using the rack-test driver instead of a selenium driver (I was missing the js: true rspec tag).

It'd be nice to detect when the test is using the rack-test driver and either log a warning or raise an exception. In general I think if a call is made to Percy.snapshot that does not result in a snapshot, we should always log a warning or raise an exception (this might not be easy / might have to occur during the "finalization" stage - I don't know if the agent work is async).

github-actions[bot] commented 3 years ago

This issue is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] commented 3 years ago

This issue was closed because it has been stalled for 28 days with no activity.