Enable by default, disable if PERCY_ENABLE=0

percy / percy-capybara

Visual testing for Capybara with Percy.

https://docs.percy.io/docs/capybara

MIT License

45 stars 23 forks source link

Enable by default, disable if PERCY_ENABLE=0 #16

Closed timhaines closed 7 years ago

timhaines commented 7 years ago

@fotinakis Change made, and specs updated.

I guess this also enables it in unknown CI providers. I suspect this is okay as it'll still require the customer to specify the key and project in the environment, and they will have seen that their provider isn't in the list of supported ones. I'd like your sanity check on this though. :)

fotinakis commented 7 years ago

LGTM 🚀

fotinakis commented 7 years ago

Per discussion, this needs a followup PR—the logic should actually be "enable if PERCY_PROJECT and PERCY_TOKEN are not nil", but disable regardless if PERCY_ENABLE=0.